Skip to content

fix: Add proper startupProbe checking if startup is completed#715

Merged
sbernauer merged 3 commits intomainfrom
fix/startup-probe
Mar 7, 2025
Merged

fix: Add proper startupProbe checking if startup is completed#715
sbernauer merged 3 commits intomainfrom
fix/startup-probe

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Mar 6, 2025 •
edited
Loading

Description

While testing a the new trino-lb feature stackabletech/trino-lb#63, we noticed that the TrinoCluster turns healthy before it is ready to accept queries.
This PR fixes that, especially in combination with stackabletech/trino-lb#68

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Mar 6, 2025
@sbernauer sbernauer self-assigned this Mar 6, 2025
@sbernauer sbernauer mentioned this pull request Mar 6, 2025
Merged
maltesander
maltesander approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice LGTM!

@maltesander maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 7, 2025
@sbernauer sbernauer added this pull request to the merge queue Mar 7, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Mar 7, 2025
Merged via the queue into main with commit ec92551 Mar 7, 2025
17 checks passed
@sbernauer sbernauer deleted the fix/startup-probe branch March 7, 2025 12:35
@sbernauer sbernauer mentioned this pull request Mar 10, 2025
Merged
@lfrancke
Copy link
Member

lfrancke commented Mar 20, 2025

Can you please add a release note snippet in the form "Previously, . With this release, ."

@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Mar 20, 2025
@sbernauer
Copy link
Member Author

sbernauer commented Mar 20, 2025

I don't think this needs a mention in the platform release notes, so I'd say the changelog is sufficient.

If we want to change the wording, we need to change it in the changelog, should I raise a PR?

@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@sbernauer sbernauer

Labels

customer-request release/25.3.0 type/bug

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbernauer @lfrancke @maltesander